Romain Vimont

For consistency with the other listeners where we use the aidl directly, maybe we could use `IDisplayManagerCallback.aidl`. This is what the wrapper `DisplayListener`s use internally (with an additional `Handler`). https://github.com/aosp-mirror/platform_frameworks_base/blob/ad73c57d691ad2cfd48b201db6cf8b053d2207ba/core/java/android/hardware/display/DisplayManagerGlobal.java#L1099-L1108

Oops, it seems this has changed in Android 14: ``` [server] INFO: Device: [Google] google Pixel 8 (Android 14) [server] ERROR: java.lang.NoSuchMethodException: android.hardware.display.DisplayManagerGlobal.registerDisplayListener [interface android.hardware.display.DisplayManager$DisplayListener, class android.os.Handler] java.lang.AssertionError: java.lang.NoSuchMethodException: android.hardware.display.DisplayManagerGlobal.registerDisplayListener...

Oh, this callback is called also on device rotation (and probably also on fold, although I have no foldable device to test). So we can probably remove the other callbacks...

@AdoPi (as author or #3979), could you check that with this PR + this diff: ```diff diff --git a/server/src/main/java/com/genymobile/scrcpy/Device.java b/server/src/main/java/com/genymobile/scrcpy/Device.java index 756af86e3..c75e2a8d7 100644 --- a/server/src/main/java/com/genymobile/scrcpy/Device.java +++ b/server/src/main/java/com/genymobile/scrcpy/Device.java @@ -106,6 +106,7...

Thank you :+1: For clarity, I extracted the rotation listener (and fold listener) to separate commits: [`reschange.3`](https://github.com/Genymobile/scrcpy/commits/reschange.3). I also made minor changes, like removing unused `onDisplayAdded()` and `onDisplayRemoved()`. However, I...

It could not work over TCP/IP. It can only detect USB devices connected via… USB.

> wouldn't it be trivial to offer the option to turn off the video mirroring of that code to provide a keyboard/mouse-only functionality over tcpip? In OTG mode, the mouse...

> Do you mean the user has to see where to click? Yes. With the default control mode (without `--hid-mouse` or `--otg`), you have no mouse pointer on the device....

In other words, when you move your mouse: - in HID/OTG mode (USB only), it moves the cursor on the Android device; - in "default" injection mode, it moves the...

Thank you for your PR. > When I run it, it warns "Can't find /usr/bin/bash -i". It's surprising, since the Exec line contains `/bin/bash` :thinking: (maybe a wrong copy-paste?) >...