Taylor Baldwin

Results 10 comments of Taylor Baldwin

First of all, thank you _so much_ for opening this PR! These technical discussions are so helpful for me. ❤️ So I pulled this down, and _wow_ it's handling all...

There are two things that still confuse me: 1. When I switched to interleaving attribute data, I made sure to measure the performance difference between the two techniques, and I...

Alright, [here](https://github.com/rolyatmax/nyc-buildings/commit/e2556803a407173f3d779f06856da2c536233385)'s where I added the attribute interleaving (one of the few commits I actually bothered to give a helpful message). I ran the parent of this commit - and...

Now I'm home looking at this again on my personal laptop and am confused as ever. So [this branch](https://github.com/rolyatmax/nyc-buildings/compare/perf-improvements), which gives up the incremental loading and splits the interleaved attributes...

Thinking about this a bit more: I'm starting to suspect that [this](https://github.com/mattdesl/nyc-buildings/blob/perf/src/create-buffers.js#L10) could play a role, given that the performance remained degraded when switching to a previous commit which _did_...

Got into work and tried switching `DYNAMIC_DRAW` back to `STATIC_DRAW`, and it runs at a smooth 60FPS again. I think this commit did the trick: https://github.com/rolyatmax/nyc-buildings/commit/ccb57d7c8e66b11f410eaf855dd8b48c8e1a6f0d Curious to know how...

Linking to this Twitter thread for posterity: https://twitter.com/mattdesl/status/988756029528793089

cc @mikolalysenko - you might find this issue interesting. A couple of us have looked at getting this up to 60 FPS but seem to be bound to 40-45 FPS....

Yeah - I totally agree! I'm afraid I'm not really making any updates to this project at the time, but if you'd like to submit a pull request, I'm happy...

Ran into this error, too. Found that, in my case, I had some `-Infinity` edge weights.