Paul Harris

Results 233 comments of Paul Harris

I'm not sure how we add this to chainStorage, as ChainStorage / StorageUpdate don't seem to have any mention of DAS...

> It seems related to > > [teku/ethereum/statetransition/src/main/java/tech/pegasys/teku/statetransition/datacolumns/retriever/recovering/SidecarRetriever.java](https://github.com/Consensys/teku/blob/e9298a1d4d5160254cf418e61554af333db5401d/ethereum/statetransition/src/main/java/tech/pegasys/teku/statetransition/datacolumns/retriever/recovering/SidecarRetriever.java#L222) > > Line 222 in [e9298a1](/Consensys/teku/commit/e9298a1d4d5160254cf418e61554af333db5401d) > > request.cancel(); > essentially the new recovering sidecar retriever is cancelling the requests and sampler...

> which seems incorrect at first sight. The sampler is not a proxy, is the originator of it's own requests, and currently is not cancelling anything so it should threat...

> I think there is a fundamental bug in `SidecarRetriever`: If it decides to not recover it must cancel only it's own additional RPC calls, not the ones that originated...

out of band we discussed the potential application of `204` with the metadata in headers, which may be appropriate... just transferring this part of that conversation, because there were a...

Hey thanks for raising this. We'll see what we can do to improve the situation. We do similar too for our validators so I feel like it's a use-case we...

I need to do more reading on these, but i know finalized checkpoint is well defined in the spec, which is what the checkpoint sync is needing but we weren't...

are we putting the change to rewards in another PR or are we looking at that in this PR too?

> I think it's already covered by adjusting `BASE_REWARDS_FACTOR`? Ok great - had missed that but yes.