consensus-specs icon indicating copy to clipboard operation
consensus-specs copied to clipboard

Spec 6s slot times (EIP-7782)

Open dankrad opened this issue 4 months ago • 10 comments

Spec for 6s slot times. Based on #4476 .

TODOs:

  • [x] Store time in milliseconds
  • [x] Rewards adjustment
  • [x] Blobs/gas adjustment (gas probably only on EL, to verify)
  • [x] Entry/exit queue logic
  • [x] Fix sync period (should not change due to shorter slot times)
  • [x] Update get_forkchoice_store
  • [x] Update on_tick
  • [ ] Fix get_slots_since_genesis logic
  • [x] Slot subdivisions (wait for @jtraglia to confirm how to do this)
  • [ ] Fix failing tests
  • [x] Adjust slot components based on #4589
Failing tests
FAILED tests/core/pyspec/eth2spec/test/electra/block_processing/test_process_consolidation_request.py::test_incorrect_not_enough_consolidation_churn_available - AssertionError: assert 63000000000 <= 32000000000
FAILED tests/core/pyspec/eth2spec/test/electra/block_processing/test_process_withdrawal_request.py::test_partial_withdrawal_request_with_high_balance - assert 100 == 101
FAILED tests/core/pyspec/eth2spec/test/bellatrix/fork_choice/test_should_override_forkchoice_update.py::test_should_override_forkchoice_update__true - AssertionError: assert 8 == 4
FAILED tests/core/pyspec/eth2spec/test/deneb/fork_choice/test_on_block.py::test_simple_blob_data - ValueError: blob_data.sidecars must be provided when post FULU fork
FAILED tests/core/pyspec/eth2spec/test/deneb/fork_choice/test_on_block.py::test_invalid_incorrect_proof - ValueError: blob_data.sidecars must be provided when post FULU fork
FAILED tests/core/pyspec/eth2spec/test/deneb/fork_choice/test_on_block.py::test_invalid_data_unavailable - ValueError: blob_data.sidecars must be provided when post FULU fork
FAILED tests/core/pyspec/eth2spec/test/deneb/fork_choice/test_on_block.py::test_invalid_wrong_proofs_length - ValueError: blob_data.sidecars must be provided when post FULU fork
FAILED tests/core/pyspec/eth2spec/test/deneb/fork_choice/test_on_block.py::test_invalid_wrong_blobs_length - ValueError: blob_data.sidecars must be provided when post FULU fork
FAILED tests/core/pyspec/eth2spec/test/deneb/epoch_processing/test_process_registry_updates.py::test_activation_churn_limit__greater_than_activation_limit - AssertionError: assert 2 == 4
FAILED tests/core/pyspec/eth2spec/test/deneb/epoch_processing/test_process_registry_updates.py::test_activation_churn_limit__equal_to_activation_limit - AssertionError: assert 2 == 4
FAILED tests/core/pyspec/eth2spec/test/electra/sanity/blocks/test_blocks.py::test_switch_to_compounding_requests_when_too_little_consolidation_churn_limit - AssertionError: assert False
FAILED tests/core/pyspec/eth2spec/test/phase0/block_processing/test_process_voluntary_exit.py::test_success_exit_queue__scaled_churn - assert 71 == (69 + 1)
FAILED tests/core/pyspec/eth2spec/test/phase0/fork_choice/test_ex_ante.py::test_ex_ante_sandwich_without_attestations - AssertionError
FAILED tests/core/pyspec/eth2spec/test/phase0/fork_choice/test_ex_ante.py::test_ex_ante_sandwich_with_honest_attestation - AssertionError
FAILED tests/core/pyspec/eth2spec/test/phase0/fork_choice/test_get_head.py::test_filtered_block_tree - AssertionError
FAILED tests/core/pyspec/eth2spec/test/phase0/fork_choice/test_get_head.py::test_proposer_boost_correct_head - AssertionError: assert 0x00000000000...00000000000000 == 0xa50391eaca0...1dcbb88f3b7c32
...

dankrad avatar Aug 04 '25 00:08 dankrad