roldanbob
roldanbob
> Thanks for the quick turn around @roldanbob, I may have a few more, specifically `DATETIME2` and `SMALLDATETIME`. I'm not sure where these came from but they're not allowed in...
Ok, will do. Thanks for researching this. On Tue, Aug 16, 2022, 8:21 AM Chris Cranford ***@***.***> wrote: > I'm fairly certain when I looked at the committers on these...
@Naros The table of data types in the Db2 documentation includes multiple entires for DATETIME2: > |`DATETIME2(0)`, `DATETIME2(1)`, `DATETIME2(2)`, `DATETIME2(3)` |`INT64` |`io.debezium.time.Timestamp` + + Represents the number of milliseconds since...
Also, further on, the _Timestamp types_ section includes the following example: > ... the `DATETIME2` value "2018-06-20 15:13:16.945104" is represented by an `io.debezium.time.MicroTimestamp` with the value "1529507596945104" I've modified that...
@Naros I'm not sure where things stand with the testing on this, but after I tried to rebase the branch to bring it up to date with changes in main,...
I've started a review, but was unable to finish today. I'll complete the work tomorrow (1 FEB). Please hold off on merging pending the completed review. Thanks.
> Thanks @roldanbob for the thorough review. The result exceeds my original expectations. The only remaining question is about Apicurio Registry vs Schema Registry. Oh, great! Regarding my comment about...
@enzo-cappa ICYMI, in my last comment, I identified an extra space on L234. Other than that this LGTM. Thanks!
> @roldanbob wrt docs, I wonder if we shouldn't just change the attribute from `ojdbc8-version`, now `ojdbc11-version` to actually just reading `ojdbc-version`. wdyt? Would this be easy to coordinate for...
@Naros Based on the Jira issue, I assume that this affects only 2.6 and later, right? Nothing to turn around for 2.5?