Andy Weiss

Results 24 comments of Andy Weiss

This is odd because by default we have `body.request.json` in the shortener_keys (https://github.com/rollbar/pyrollbar/blob/master/rollbar/__init__.py#L328,L333) which is intended to reduce the size of the payload by only having a fixed number of...

I think 2 sounds reasonable. In other SDKs we don't merge extra data into data.body.message but into data.custom basically at the top level

#172 needs to get addressed and this appears to go towards that, but I'm going to bump this to the next release because getting into the weeds of twisted is...

With the current code, as far as I can tell, there are no infinite loops in the case of an SSL error. If you get rid of the add/remove observer...

I think the solution here is that we should have an option to include backtraces with messages which is off by default. The implementation being what is in this gem....

Yeah that's what I understood and I agree, we might as well just have one option.

The thing stopping the easiest implementation is that the API spec does not allow both a trace and a message as part of the body of the item payload. So...