Julien

after thinking twice, the TLS servername should come from the header, not the other way around.

Can you add white lines before and after the examples, and add DCO? Thanks

Is it relevant for Prometheus? Le mar. 17 mai 2022, 13:37, Boris Petersen ***@***.***> a écrit : > This add the ability to utilize sigv4 signing for all AWS services...

Where would this be used? When we load from file, we should get a String, not a Secret. The code path should be different: if a Secret is used directly,...

That looks fine to me except the node exporter with a tux logo, which excludes our BSD/Darwin/* users. Can you pick a more generic logo? (even if the guide is...

For legal reasons, we require that all commits are signed with a [DCO](https://developercertificate.org/) before we can merge them. See [this blog post](https://www.cncf.io/blog/2016/11/08/cloud-native-software-can-trust/) for considerations around this. This means that the...

2.15 and master might differ on this.

mmh no. I was thinking that maybe the new parser was more strict about this. it is not.

Yes it's a bug because the docs say otherwise as implemented.

Thanks! I think the current path is more 'logical' and easy to use than the proposal. Does this really cause performance issues?