docs icon indicating copy to clipboard operation
docs copied to clipboard

Update grafana.md to include Exporter Quickstarts

Open scoren-gl opened this issue 3 years ago • 3 comments

Updated pre-built dashboard section to include a link to the exporter-specific quickstarts.

scoren-gl avatar Apr 14 '21 23:04 scoren-gl

That looks fine to me except the node exporter with a tux logo, which excludes our BSD/Darwin/* users. Can you pick a more generic logo? (even if the guide is only for linux I find it a bit misleading :) )

roidelapluie avatar Apr 15 '21 09:04 roidelapluie

For legal reasons, we require that all commits are signed with a DCO before we can merge them. See this blog post for considerations around this.

This means that the last line of your commit message should read like:

Signed-Off-By: Your Name <[email protected]>

If you are using GitHub through the web interface, it's quickest to close this PR and open a new one with the appropriate line.

If you are using Git on the command line, it is probably quickest to amend and force push. You can do that with

git commit --amend --signoff
git push -f $remote $remote_branch_for_pr

As always, be careful when force-pushing.

roidelapluie avatar Apr 15 '21 09:04 roidelapluie

@scoren-gl reminder-poke :)

RichiH avatar May 05 '21 10:05 RichiH