Rohit Jain

Results 16 comments of Rohit Jain

[base.py](https://github.com/pydata/pandas-datareader/blob/master/pandas_datareader/base.py) is the base class above which all the APIs for different source of data needed to be implemented?

Thanks for the help. I have already started working on it. I am facing an issue with the implementation I want user to provide me with Interval of the data...

@gliptak can you review my code for this and provide me with feedback on how to improve the implementation. I still need to write docs and tests for this. [Here...

I have written tests for checking the dimensions and columns of the response. I am relatively new to writing tests can you suggest me what more checks to add in...

For now I will start a PR for the above branch and keep updating new test cases and improvements.

It was available when I created a CR but @dahifi recommended something better and I did not had bandwidth to implement it. So if anyone else is willing to take...

@addisonlynch Can you share your implementation? I would love to contribute to this.

Check out the https://pwabuilder.com/ for this.