Rohit bhagat comments

Results 7 comments of


                                            Rohit bhagat

Added wrapper for UPPER() and LOWER() functions for CHAR and NCHAR to handle padding for shorter strings

Kindly add newly created test BABEL-3395 in schedule files of upgrades

[Bug]: REGRESSION Comparing a bit value in a CASE statement to assign a CHAR type results in error

Thanks @bill-ramos-rmoswi for reporting this issue. Please note that we are already tracking this issue and will take it up soon.

[Bug]: sys.sql_expression_dependencies definition is simply a null returning view that is needed CI/CD tools like Redgate Schema Compare

@bill-ramos-rmoswi , Thanks for the proposed changes. I am currently reviewing your proposed changes and will share feedback soon.

[Bug]: sys.sql_expression_dependencies definition is simply a null returning view that is needed CI/CD tools like Redgate Schema Compare

@bill-ramos-rmoswi proposed changes looks good to me on high level. Can you please raise a pull request for this changes. Also can you please add a high level design summary...

Fixed UDT handling for CASE statement when branch expression is of String Datatype.

Tests for sysname and UDT looks good to me. But tests for `MAX` typmod does not look sufficient enough to test the handling we added for `MAX` typmod. One such...

Fix CONVERT function behavior for BINARY and VARBINARY types

Kindly make sure tests covering following scenario's are added for both `CONVERT` and `TRY_CONVERT` - expression is empty string - when style is not specified, style is 0, style is...

[Bug]: Computed string column gives unmapped error

> [@rohit01010](https://github.com/rohit01010) I am curious if system function concat could be marked immutable ? @tanscorpio7 Yes, `sys.concat` should ideally be immutable, but currently `sys.concat` is dependent on PostgreSQL function `ARRAY_TO_STRING`...