Roger Ng

Results 46 comments of Roger Ng

Created PR #25 for Traditional Chinese.

A dirty workaround plunker http://plnkr.co/edit/QzPLG3SbEIkVEbNAE0BZ?p=preview

Make sure you have the second function argument (cancel one) to avoid the warning message. ``` modalInstance.result.then(function() { // Success }, function() { // Cancel }); ```

I am having the same issue and was about to create one. The same issue happens in pager as well. The fix is to remove those href in uib/template/pagination/pagination.html and...

I just realize removing the empty `href` would break the CSS. My current workaround is to change the empty `href` to `href="/"`. Here is the Plunker that fixed the issue...

The same issue happens in ui-router as well. Hope my information helps.

@scolt There is another workaround before this issue is fixed. According to the issue raised in ui-router, the workaround is to add a customized CSS. However, this would break the...

In the [Bootstrap component document](http://getbootstrap.com/components/#disabled-and-active-states), only `li` element requires the `disabled` class. It should be safe to remove the `ng-disabled` in `a` element. ``` html « 1 (current) ... ```...

@wesleycho If you think removing the `ng-disabled` in `a` element is a good solution, I can help create the pull request.

@wesleycho How about removing the `uib-tabindex-toggle` directive and make use of `ng-attr-tabindex`? This should have avoided the accessibility violation. ``` javascript {{::getText('first')}} {{::getText('previous')}} {{page.text}} {{::getText('next')}} {{::getText('last')}} ``` https://plnkr.co/edit/bLPJL88GCB6xGuxjXmp1?p=preview