rofl0r

Results 904 comments of rofl0r

i finally managed to create a test environment using a sabotage linux arm rootfs, and i built gnuboy like this: ``` CFLAGS="-O0 -g3" CC="/home/user/musl-cross-make-6.3.0/arm-linux-musleabi/bin/arm-linux-musleabi-gcc -L /home/user/x-prefix/arm/lib -isystem /home/user/x-prefix/arm/include" LDFLAGS="-Wl,-rpath-link=/home/user/x-prefix/arm/lib" ./configure...

it's odd that you have libpng in the trace, because we don't use it. can you figure out where it is pulled in from ? anyway i suspect this patch...

ehm, your copying my commits there but i don't see myself mentioned as author. you can preserve authorship with git format-patch / git am or git `commit --author="rofl0r "` also...

> But please note that I ALWAYS give credit on my release page that's precisely what the "author" field of git commits is for. but don't worry, you can turn...

do the current changes to libc-compat.h fix this issue?

> we would like to work on improving gettext-tiny. did you encounter any specific issues so far ? > do you have any preference on how poparser should be reimplemented?...

> char line[8192] maybe we should just allocate that dynamically to 8KB on start and double its size whenever necessary (with realloc, so contents stay available). note there's also convbuf,...

> Reason why msgfmt failed is that msgmerge printed some super long lines oh, good find! was it because of > But later i noticed some other "bugs". Specifically, three...

i can see the benefit of making parser more robust, otoh a big rewrite like this probably introduces some new bugs... what do you think about fixing only the msgmerge...

> Or we just patch and push to the master? i guess we can just fix master directly