Rory Finnegan

Results 223 comments of Rory Finnegan

Hmmm, I just realized that a another benefit of moving the condition from the above comment to a function that dispatches would be that you could define custom logic for...

This is an intentional design choice in order support passing tuples of values. ``` # From https://github.com/invenia/Impute.jl/blob/master/test/imputors/replace.jl#L23 imp = Replace(; values=(DateTime(0), -9999, NaN, "")) df_table = DataFrame( :time => [missing,...

Yeah, you're hitting the somewhat unintuitive part where we need to initialize the `missing`s with a real value. It looks like we're using `Substitute()`, which is where the `150` is...

In retrospect, the better way to do this is to support `skipmissing` distances in Distances.jl and then extend NearestNeighbors.jl to include that in the Union type of which metric you...

Is there a full traceback? Can you confirm that the `Manifest.toml` file exists? JLSO will also read the active project manifest when saving files, this is how we retain a...

Typically, if you start Julia with `julia --project=.` it'll activate a local environment in your current working directory. You can then add only the packages you need for the project...

Would it be a bug with JLSO though? This is all we're doing `joinpath(dirname(Base.active_project()), "Manifest.toml")`.

Yeah, but unless we're inspecting the serialized objects this feels like more of a Pkg issue?

Hmm, maybe we should do that in another package? I've heard people complain that JLD2.jl doesn't do that either.