Rory Finnegan
Rory Finnegan
Hmm, I wonder if rather than handling this in the type structure we could just support it through duck typing? Basically something like requiring methods for `isleftbounded(::AbstractInterval{T})` and `isrightbounded(::AbstractInterval{T})`. Pros:...
I'm pretty sure that will break. I'm not really sure what the best solution is.
Ping? Would folks like me to prioritize non-exported constants on Windows over building system images on windows?
Hmmm, the only way we can keep the windows constant is by setting it in an `__init__` function?
Thanks, seems reasonable. I've started watching that PR and whenever it's ready to be merged I'll run the tests on that branch.
Yeah, there's an open MR to support UNC paths. I don't use windows regularly, so you might want to comment on this MR https://github.com/rofinn/FilePathsBase.jl/pull/12
LGTM, reminder to bump the minor release. I'm inclined to holdoff on changing the String fallback for now. Might want to make an issue for it though?
No, this MR needs a rebase before we can proceed.
Yeah, I feel like `transform` is a general enough term that we shouldn't export it. `using StatsBase: transform` is easy enough to do.
I'm confused... what's changed in base? The method signature it's claiming is ambiguous seems strictly more specific than the candidates.