LibPQ.jl icon indicating copy to clipboard operation
LibPQ.jl copied to clipboard
verified publisher icon iamed2

Support and default to UUID for PostgreSQL uuid

Open iamed2 opened this issue 3 years ago • 5 comments

Closes https://github.com/invenia/LibPQ.jl/issues/260

This adds binary format parsing for UUID and sets the default Julia type for PostgreSQL's uuid to Base.UUID. The import relies on the UUIDs stdlib export for stability's sake.

Array support was easy enough to add as well.

Open question on whether changing the default type away from the String fallback needs a major version update: https://discourse.julialang.org/t/anyone-fetching-uuids-using-libpq-jl/89395/3

I think if people conclude it does, I'll change to ensure this doesn't set the default but still supports the same operations when UUID is specified.

iamed2 avatar Oct 27 '22 20:10 iamed2

Seems to work well. Can it be merged?

robsmith11 avatar Feb 14 '23 11:02 robsmith11

LGTM, reminder to bump the minor release. I'm inclined to holdoff on changing the String fallback for now. Might want to make an issue for it though?

rofinn avatar Feb 14 '23 23:02 rofinn

Good to merge?

robsmith11 avatar May 15 '23 17:05 robsmith11

No, this MR needs a rebase before we can proceed.

rofinn avatar May 15 '23 19:05 rofinn

Rebased: https://github.com/iamed2/LibPQ.jl/pull/288

robsmith11 avatar Dec 31 '23 03:12 robsmith11