Rodrigo Primo

Last year I was working on a project using python-openid and, after opening a few pull requests here, @willnorris gave me access to the repository. Unfortunately I'm not working with...

Just noting here that some acceptance tests are failing and they seem to be failing due to the changes made here. I will check and fix the tests after I...

@costasovo, I fixed the acceptance tests that were failing and this PR is now ready for a final review.

Sorry for the delay to reply, @veljkho. > When I do some change and revert it back to normal state like I did no change, I still see dialog that...

@costasovo, I'm requesting a new review from you in this PR as I added a new commit to display the confirmation message only if there is actually a change in...

@costasovo, please see the commit message of the last commit for more details on my reasoning for choosing the approach that I chose. I'm not sure if there is a...

Thanks for your input, @costasovo. > If we decide to keep the comparison of states here in the selector, do we still need to keep tracking the state state.save.hasUnsavedChanges? After...

Good point On Fri, Oct 7, 2022, 05:05 Rostislav Wolný ***@***.***> wrote: > ***@***.**** approved this pull request. > > Good job! Thanks 👍 > > I guess I got...

Thanks, @veljkho. I missed this problem with the "Or Cancel" button. It behaves differently than the rest of the page and that is why it was not working. It should...

Changing the reviewer to @samnajian as Jan L. is AFK this week.