rodolphecombe

Ok, this makes sense. It could have the second_unit in the case of [heal_unit] though, as it is a key of this tag.

Yes, heal_unit would then need a fire_event key. Why does it makes it inconsistent? [heal_unit] already accept filter_second (the second unit is used for the animation). Unless you mean that...

I see what you mean. But this behavior already exists. In the case of a [kill] with no filter_second and fire_event=yes, the last breath event is fired with second_unit being...

I understand the argument. I think it is therefore fine if on_heal has not second_unit as it is not the core of the FR. Should I edit the first message?

No problem. I am waiting for some feedback from EmperorZombie they was supposed to test if my implementation fits their needs. The commit is ready but I have not yet...

@Pentarctagon I looks like I either cannot reopen the PR myself and do not know how to do it. Could you please do it for me? I would like to...

So be it then. At least the PR with the working code will be here if someone see more interest in adding that later on. I do not think it...

> Are you asking something you cant already do in your addon by overriding wesnoth.wml_actions.harm_unit? The add-on author might not be the one having written the [harm _unit]. It could...

> If you override wml tag then everyone who calls it, including mainline, uses your version of tag. That is actually quite interesting. I will try to make a [harm...

I made a first PR for this issue (https://github.com/wesnoth/wesnoth/pull/8995), adding a pre harm and a post harm event. After discussing with Ravana, I think the two custom events could be...