rodolforg

> Instead of that you can extract `push_filename(...)` method and rename it to `escape_filename(...)`. Would it be a function directly in `synfig::OS` namespace? By the way, what is better: `synfig::OS`...

> > Instead of that you can extract `push_filename(...)` method and rename it to `escape_filename(...)`. > > Would it be a function directly in `synfig::OS` namespace? By the way, what...

> Instead of that you can extract `push_filename(...)` method and rename it to `escape_filename(...)`. Not all filenames must be escaped; it depends on what OS we are using, for example....

I can't test on Windows for now. :(

Argh, I don't know why the pipe suddenly stops writing on Windows when exporting via FFmpeg

I believe now I got it right :)

> I suggest moving the popen code from ffmpeg module only to the os module first (without changing current behavior). It indeed works, but not allow stdout/stderr redirection to a...

You can test it XD ~~Ignore last commit: it's broken. You''ll use Win32 API. Four commits back ([refactor: ImageMagick importer now uses new synfig::OS::run_sync()](https://github.com/synfig/synfig/pull/2491/commits/c527e9364ed479a49b4d6ad3e6f50941017d8e7c) ) is (still) the _wpopen implementation.~~...

Note: - with `_wpopen` on Windows: no stdout/stderr/stdin redirection to/from a file. It means `trgt_dv` keeps broken. - with Win32 API: pretty slow exporting emprty file with 1920x1080 pixels via...

> I tested this PR (Release build) and it takes about 6 seconds, which is basically the same as on Linux. Are you saying it is properly working? :o I...