Rodolfo Gobbi De Angeli
Rodolfo Gobbi De Angeli
@tshelburne thanks for the lib before anything. I came to this issue to say that I couldn't make the lib work by applying the middleware, when I did this, all...
Hi @Sparticuz This is tricky indeed, you need to simulate an event object when calling the function, check this comment from another discussion about this issue: https://github.com/gpbl/react-day-picker/discussions/2676#discussioncomment-11984571.
@gpbl Thanks for the encouraging message! Let me give more context from what I understood. The logic checks if there are any `disabled` dates within the selected date range (and...
Hi @jiwon79 Thanks for the feedback! @gpbl I agree with @jiwon79, I noticed this behavior and was planning to discuss at some point. Internally the `DayPicker` only uses the `selected`...
@gpbl I tested the idea of the `dafaultSelected`, there are some caveats about it, even about the current API, lemme share my thoughts. 1. I think `dafaultSelected` could indeed be...
@gpbl for sure, thanks for the feedback 👍 > While I agree the uncontrolled mode should be removed Thanks for providing this feedback. I wanted to confirm if it also...
Sorry @gpbl, it took me a while to see this PR. Looks good indeed!
Hi @gpbl I created a draft PR for now because I'd like to discuss with you what I found and align with you on how to implement the rest. There's...
@gpbl Thanks for the suggestion, I missed hoisting the `differenceInCalendarDays` call, which is indeed better. Just one important detail, we cannot rely only on the visible `months` returned by the...
@gpbl Great work! I see that you already set up the performance tests, that was quick 👏 Two points about it: 1 - Currently the `performance` CI check is failing...