Chris Roche
Chris Roche
We do 😅! https://github.com/lyft/protoc-gen-validate/blob/master/checker.go
Since the original discussion, it appears we are indeed vendoring the gogo proto extensions, so we could feasibly annotate everything appropriately now.
This is an excellent idea. First order of business would be to define what it means for a change to an annotation to be considered breaking.
Hi @carsonoid! The team is focused on [protovalidate](https://github.com/bufbuild/protovalidate) at this point, but we will consider any bug fixes or simple changes. As the error messages are pretty language specific in...
Thanks for the patch (and everyone's patience on getting this merged)!
Hey, thanks for the patch! Can you add some tests to cover the expected behavior here? I'll enable CI once you're ready.
> Bzlmod itself doesn't require it but something else could. (Sorry, unfamiliar with bzlmod and only weakly familiar with bazel as a whole) I mean, do we need to execute...
Hi @cnoon! Thanks for praise and feedback. 😁 You hit the nail on the head with the value not being included in the error to avoid PII or security concerns....
Hey, @weeco! The `KnownRegex` are a holdover from the protoc-gen-validate days that we will likely deprecated prior to v1. Instead of putting this feature there, I'd say it's better suited...
Hey @yangzh! Thanks for the thoughtful question! Out of the box, CEL does not have a lot of reflection support to get information off the types themselves. Enums especially are...