Gabor Roczei

Results 27 comments of Gabor Roczei

@cloud-fan, @hddong, @dongjoon-hyun could you please review my changes? Thanks!

@cloud-fan Could you please take a look when you have some time? This PR is a follow-up PR for https://github.com/apache/spark/pull/32364. Thanks!

> we should also update `V2SessionCatalog.defaultNamespace` @cloud-fan, did you mean this change? ``` diff --git a/sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/V2SessionCatalog.scala b/sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/V2SessionCatalog.scala index efbc9dd755..23775c3ae0 100644 --- a/sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/V2SessionCatalog.scala +++ b/sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/V2SessionCatalog.scala @@ -33,6 +33,7 @@ import org.apache.spark.sql.connector.expressions.Transform...

> > override val defaultNamespace: Array[String] = Array(SQLConf.get.defaultDatabase) > > Yes @cloud-fan Ok, I have fixed this.

> Is this a common behavior in other databases? @cloud-fan Good question. The reason that we cannot delete the user specified default database because we have the following if statement...

Thanks @cloud-fan, I have implemented this and all tests passed. As I see we have resolved all of your feedbacks.

Hi @cloud-fan, Thanks for the feedbacks, I have resolved all of them. Unfortunatelly I did a mistake during the version magament but I have already resolved with git rebase /...

Hi @cloud-fan, All build issues have been fixed and all of your feedbacks have been implemented. Latest state: ``` $ bin/spark-shell --conf spark.sql.catalog.spark_catalog.defaultDatabase=other_db Setting default log level to "WARN". To...

> LGTM except for 2 minor comments Thanks @cloud-fan! I have implemented these two comments.