react-native-webview-comlink icon indicating copy to clipboard operation
react-native-webview-comlink copied to clipboard

Feature/added jsi nterface

Open khalid64927 opened this issue 2 years ago • 1 comments

khalid64927 avatar Nov 29 '22 03:11 khalid64927

HI @khalid64927 , thanks for the PR! I saw you are adding some constraints to the native-to-web interface to allow web side setting a web-to-native interface to native. It's not really necessary IMHO, client could arhieve the same thing without updating this library. what do you think?

As mentioned in the README (and the library name), this library is inspired by Comlink, so if we were going to add built-in support to web-to-native workflow, I'd prefer to enchance it with adding something like Comlink.proxy, it makes sense to support it (I was not sure about if it's really necessary and we don't need it in my previous RN app) as other platform specific javascript interface has the similar behavior - e.g. WebView2 AddHostObjectToScript supports to return another proxied (ComVisible) object in the host object methods.

rocwind avatar Dec 19 '22 03:12 rocwind