rocketpool

rocketpool copied to clipboard

On stake.rocketpool for both staking ETH and migrating RPL to 2.0 and I believe for all functions, the priority fee suggested in metamask is too high. It is simply being...

negamax

Bumps [tar](https://github.com/npm/node-tar) from 4.4.15 to 4.4.19. Commits 9a6faa0 4.4.19 70ef812 drop dirCache for symlink on all platforms 3e35515 4.4.18 52b09e3 fix: prevent path escape using drive-relative paths bb93ba2 fix: reserve...

dependabot[bot]

`StatusUpdated` is emitted 2 times in the same function with same inputs

1

`StatusUpdated` is emitted 2 times here: https://github.com/rocket-pool/rocketpool/blob/bf79937/contracts/contract/minipool/RocketMinipoolDelegate.sol#L191-L207 I think the first emit is unnecessary? You can see this on the current prater-testnet: https://goerli.etherscan.io/address/0xb6179bef8927ccb96cc0d33a76f379d48ca62142#events

guybrush

Hi guys, interested in the project. I am wondering if it would help to add a docker image to run rocketpool in. That might be easier to work on various...

oliverbaehler

It would be great if there was a security.txt document added to this repo to allow for bug bounty hunters and researchers to know rules regarding bug bounty in your...

mrthankyou

Shouldn't this be set to 7200 to equal 24 hrs.

1

https://github.com/rocket-pool/rocketpool/blob/a81c41c3b9cf46de76cfd58e34ac72b0dfdbb037/contracts/contract/dao/protocol/settings/RocketDAOProtocolSettingsMinipool.sol#L24 If I'm understanding is the number 5760 a unit of block time. If so I recommend that this be changed to 7200 anticipating 12-second blocks post the quick merge....

htimsk

"npm test" failed

6

hi After `npm install`, i run `npm test `. It failed , with this message : `Contract: RocketNodeManager admin: can set a node's trusted status: Error: value out-of-bounds (argument="_index", value="-1",...

gerisse

Coverage currently isn't too bad, but lets get it as close to 100% as we can. I've added the coverage utility, so just run `truffle run coverage` to see the...

darcius

Add a safety cap on the amounts reported back by the trusted nodes just as an extra safety measure. We could have a swing cap of say 0.5% every 24hrs...

darcius

Wallet test-recovery: panic: runtime error: slice bounds out of range [:4] with length 3

2

Running rocket pool `1.6.3` on Ubuntu. Repro: 1. `rocketpool wallet t` 2. Enter `24` 3. Enter `asdf` for "Word Number 1" 4. panic: runtime error: slice bounds out of range.......

jpenglert