rocketpool icon indicating copy to clipboard operation
rocketpool copied to clipboard

"npm test" failed

Open gerisse opened this issue 4 years ago • 6 comments

hi After npm install, i run npm test . It failed , with this message : Contract: RocketNodeManager admin: can set a node's trusted status: Error: value out-of-bounds (argument="_index", value="-1", code=INVALID_ARGUMENT, version=abi/5.0.0-beta.153) an idea ? thanks

gerisse avatar Oct 30 '20 10:10 gerisse

Hey @gerisse! Are you getting this error on master branch? I just ran the tests on master and they all passed for me.

What version of node are you running? You can find that out by typing node -v in terminal.

darcius avatar Oct 31 '20 01:10 darcius

yes, Darcius, i 'm on master branch. node -v gives v15.0.1 . Thanks

gerisse avatar Oct 31 '20 07:10 gerisse

@gerisse Ah ok, found the issue! We hadn't tested on > Node 13 LTS before, so I upgraded to Node 14 LTS which caused issues with our versions of Ganache / Truffle. Updated those and then encountered your error which it seems was due to a bug in that unit test which was being ignored in previous node versions.

If you do a fresh pull + npm install && npm run test, it should all work for you now :+1:

darcius avatar Nov 03 '20 00:11 darcius

ok , so i did the update , and choosed the node 14 version. But the same issue appears :-(

gerisse avatar Nov 04 '20 19:11 gerisse

That is odd, it appears fixed for me. Did you run a git pull before running the tests again?

darcius avatar Nov 04 '20 22:11 darcius

yes, i pulled it before

gerisse avatar Nov 11 '20 15:11 gerisse