bolero icon indicating copy to clipboard operation
bolero copied to clipboard

Inconsistencies / code smells

Open AlexanderFabisch opened this issue 8 years ago • 1 comments

  • [ ] some parameters are given as environment variables (BL_SEED, BL_LOG_PATH, BL_CONF_PATH), some are read from learning_config.yml
  • [x] some environments don't use BL_CONF_PATH: CEC13, FunctionApproximation, MarsEnvironment / this will be addressed with #41
  • [x] there is commented code in MountainCar
  • [x] ... and in the Controller
  • [x] ~~there is no behavior search in C++~~
  • [ ] sometimes it would be good to use smart pointers

AlexanderFabisch avatar Dec 17 '17 12:12 AlexanderFabisch

  • The BL_CONF_PATH is used to define where to find the learning_config.yml, all environment should use the environment variables.
  • The learning_config.yml defines the configuration for a learning application. While the environment variables can define parameters for single learning runs. Like when performing a learning application changing the log folder every run without overwriting the learning_config.yml.
  • I will check the commented Code and remove it.
  • The C++ behavior search implementations aren't open source yet.
  • We can discuss where we should use smart pointers, they are not always necessary. ;-)

malter avatar Jan 15 '18 11:01 malter