Roch Devost

Results 363 comments of Roch Devost

I think this was mostly added as a safety net, but I don't know the scenarios where the prototype would not be accessible by `getOwnPropertyDescriptors`. However, I cannot reproduce this...

> If you want, I can add a check for that and special-case it. If you don't think it's a valid real-world case I don't really mind. I was more...

Thank you for the upstream fix! Do you think this could be done in a more generic way? We have more native extensions than just profiling and we have more...

> Note that this now removes support (i.e. no longer instruments) Next.js >=12.0.0 =12.

> maybe that's the reason we never updated it [This](https://github.com/DataDog/dd-trace-js/pull/468) was the reason a long time ago, but I have no idea if it's still true today (hopefully not as...

Using `RUSTUP_USE_CURL=1` still hangs for me. Any other workarounds?

It does look like it's able to get a bit further when using `RUSTUP_USE_CURL=1`, but now it gets stuck at installing cargo: ``` info: installing component 'cargo' verbose: creating temp...

@rami3l Not sure if I'm doing this right, but I added `RUSTUP_UPDATE_ROOT=https://dev-static.rust-lang.org/rustup` as an environment variable before running the command and I am still getting the same issue. The command...

> The thing here is that we're currently considering the removal of the cURL backend (possibly as early as in 1.28), so it's a must that we minimize the number...

I tried to disable cURL and use the default reqwest backend instead with the 1.27 beta, and it also didn't change anything compared to before. Here is the output: ```...