Roch Devost

Results 273 comments of Roch Devost

> I hope one day to be able to merge it with OT. So basically, it is expected that this library will eventually be deprecated? > I saw that DD...

I am thinking on moving to `ot-tracer-` and `ot-baggage-` as text map prefixes. It seems to be what every example and most implementations are doing right now, so there are...

My observation was based on these libraries: https://github.com/opentracing/basictracer-go/blob/master/propagation_ot.go https://github.com/opentracing/basictracer-python/blob/master/basictracer/text_propagator.py https://github.com/opentracing/basictracer-javascript/blob/master/src/propagation.js https://github.com/lightstep/lightstep-tracer-javascript/blob/master/src/imp/tracer_imp.js However, I agree that this is in no way a standard. I was just thinking that if someone would...

@taishi8117 Can you share the dependencies from your `package.json`? This would help isolating if the issue could come from a specific plugin.

You can add dependencies for a test in a new entry under `pg` in [externals.json](https://github.com/DataDog/dd-trace-js/blob/5348eaad6f1a86d57b87ffd3de6397feb1dcb417/packages/dd-trace/test/plugins/externals.json). Then to use it you would have to require it from the `versions` folder as...

We could indeed recommend this module when using Webpack. It's possible that it won't be possible to use it in some setups, but I think it would work for most...

@armenr Simply using Babel should not cause any problems, although you have to make sure to avoid hoisting, similar to what we recommend for TypeScript in the [setup docs](https://docs.datadoghq.com/tracing/setup/nodejs/#typescript), otherwise...

@armenr Assuming that the tracer is initialized synchronously in `connectTracer.js`, then it looks correct. Which auto-instrumentation seems to be missing?

For `graphql`, it needs to be set as an external in the Webpack config since it's only required when the plugin is loaded, which is not the case when `graphql`...

@amitizle Are you referring to the issue with `spdx-license-ids`? Is this still an issue?