Robert O'Callahan

Results 250 comments of Robert O'Callahan

The mwindow code looks fairly complicated and I don't know what its requirements are without studying the code a lot more. However, I think the natural way to do all...

> Have you noticed the mmap calls being a significant performance issue or just noticed that there's a lot of them? They cause [rr](https://rr-project.org) to completely blow up when recording...

On Linux you might get an even bigger speedup by using `process_vm_writev`.

The main features that make `process_vm_writev` attractive here are that you don't need a file descriptor and that you can write a large number of discontiguous ranges with a single...

Actually `process_vm_writev` can't write to read-only mappings, so that's not an option here.

I'm getting this too. It's causing frequent test failures in our CI. When things are working, the Stripe CLI reports two `checkout.session.completed` events per session completed, one with endpoint.api_version "2020-08-27",...

Right around the time of the failed checkout session I do get ``` time="Tue, 23 Mar 2021 01:04:59 UTC" level=debug msg="Sending text message" prefix=websocket.Client.writePump time="Tue, 23 Mar 2021 01:04:59 UTC"...

We're working around this in our CI by scanning the stripe-cli debug log for "Disconnected" messages and if we see one, abandoning the test without reporting a failure.

FWIW I am seeing cases where an event is being totally ignored because "Received event with non-default API version", but there is no disconnection recorded in the log :-(.

> does adding CAP_SYS_PTRACE and using seccomp=unconfined seem correct for allowing rr to work inside Docker containers? Yes.