robust
robust copied to clipboard
turtlebot/3ea2c30: liveness -> harmless?
turtlebot/3ea2c30 is about an env hook (basically a Bash script 'plugin') trying to find a directory which doesn't always exist (as it's a directory from a different package, which isn't listed as a dependency of the package in which the failing env hook is located):
https://github.com/robust-rosin/robust/blob/7e3932c4906a2851d1f84bfd96ecaa58924c9f57/turtlebot/3ea2c30/3ea2c30.bug#L4-L14
This is classified as SOFTWARE:LIVENESS
.
However, the net effects of that env hook failing are essentially:
- an annoying warning on the console every time a user
source
s theirsetup.bash
(ie: activates a workspace) - the
TURTLEBOT_MAP_FILE
environment variable not getting set
but the base functionality of the package itself (ie: turtlebot_bringup
) is not affected. The robot can still be controlled, no software will fail to work, except some other package which might use this variable (some .launch
files in turtlebot_navigation
).
Do we feel this is sufficient for a LIVENESS
label?
Edit: and the env hook also only sets a "sane default".