Robert J. Simmons

Results 29 comments of Robert J. Simmons

This seems pretty straightforward, I'd really like to see #59 resolved, and so I'd be interested in trying to attack this over the next couple days if noone else has...

Here's a small oddity - the first line of https://github.com/MLton/mlton/blob/master/basis-library/integer/int-inf0.sml is clearly a typo, since it cuts off Suresh Jagannathan's name. This was introduced in dcb42e5975, presumably this should correctly...

I see this as simpler, and I kinda don't think this even needs to/should be a command line argument? The spec in my mind is "an autoformatter turns a valid...

Aaaahhh, yes: everything does work with Nearley 2.11.1. If I'd realized it was a recent update I woulda thought to try that. Thanks!

I've confirmed that 2.11.1 works for my larger case as well, and added a slightly larger but more realistic grammar example as a test case in the PR above. (Presumably...

Bizarrely, SML/NJ also warns about this file (MLton does not), so it may be an imprecision in the definition instead of an outright bug.

So, MLton MLB annotations can already handle "nonexhaustiveMatch error". I agree this would be a reasonable _default_ for SML-CIDRE - if you want it to be just a warning, you...

Okay; it's still pretty silly that I have to give the conslist refinement, and even sillier that if I give ``` (map (*[ t) -> Term.term_t conslist -> t conslist...

A related error is that this doesn't check, even though, intuitively (speaking as a user) it should: ``` (*[ val f: unit -> true -> true ]*) fun f x...

Figured out how to get Rust profiling working, and 99% of the time for that benchmark is spent in the `add_impl` function of `src/util/edit_map.rs` - it seems like [this loop](https://github.com/wooorm/markdown-rs/blob/60db8e5896be05d23137a6bdb806e63519171f9e/src/subtokenize.rs#L264-L271)...