Rob Ramsay
Rob Ramsay
> Thank you! The gitignore while traversing fix looks good, though we still should ignore sub-directories when the `-r` flag is not being used in osv-scanner. (Probably requires making `readIgnoreFile`...
Thanks for the clarification @another-rex . So you preference is for the command `osv-scanner ~/projects/_git_repo/dir_a/dir_b` to pick up: - `~/projects/git_repo/.gitignore` - `~/projects/git_repo/dir_a/.gitignore` - `~/projects/git_repo/dir_a/dir_b/.gitignore` but not - `~/projects/git_repo/dir_a/dir_b/subdir/.gitignore` - `~/projects/git_repo/not_in_original_path/.gitignore`...
> Huh TIL about .git/info/exclude. I think we should respect the .git/info/exclude as well, since we are trying to match git behavior There's also a `/etc/gitconfig` file, and user-profile setting...
Can you assign this to me please @another-rex
I've done a bit more poking and managed to create git-repo with submodules that doesn't have a backing github repo, so re-utilising the existing fixture based testing —`func Test_scanGit`— looks...
Broadly speaking I like the direction of this. I've used feature flags in the past, and the systems were generally over the top complication for most of what we do...