Rob Pickerill

Results 10 comments of Rob Pickerill

Hi @jantman - I'm sorry to hear this. Let me take the opportunity to thank you for all your effort here. I'm just checking in, is this still the case...

> Beyond that, the main thing that I could really use some help with is getting some of the current PRs merged to a branch that's ready for release. Let...

Hey Jason, apologies I missed last week, got sidetracked with work and other items. Awesome, you've merged PR's - is there anything you need help with?

hey, I quickly checked and directory services isn't listed as a supported service for Osaka (ap-northeast-3): https://docs.amazonaws.cn/en_us/general/latest/gr/ds_region.html Does it fix anything if you ran this with `--skip-service` for Directory Service?

Hi, thanks for the follow up @zroubalik. It is an empty response, so in this case, there are no metrics being returned from the GetMetricData call. We fall into this...

Thanks @zroubalik -- just to check, would the backwards compatibility be enough to add a new metadata option for the cloudwatch scaler: `errorWhenMetricValuesEmpty`, that's optional, and defaults to false to...

Thanks, you can assign this to me, I'll send over a PR for review soon

Hi, the issue is here: https://github.com/kedacore/keda/blob/main/pkg/scalers/postgresql_scaler.go#L171. Using `NullFloat64` may allow a check against null after the scan. Also, worth noting that you might be to able to use the [COALESCE](https://www.postgresql.org/docs/current/functions-conditional.html#FUNCTIONS-COALESCE-NVL-IFNULL)...

I added end to end tests here for both minMetricValue and errorWhenNullValues to cover off both scenarios. I need to tidy them up a little, which ill do over the...

> @robpickerill any updates here please? Good for review, all comments are addressed