ycm-cmake-modules icon indicating copy to clipboard operation
ycm-cmake-modules copied to clipboard

Import FindOctave version of it in the wild

Open traversaro opened this issue 7 years ago • 1 comments

A FindOctave.cmake was added in https://gitlab.kitware.com/cmake/cmake/merge_requests/2630 to CMake upstream. We can check if that one is compatible with the version that we ship, and eventually import that one via cmake-next to remove the 3rdparty/cmake-wiki directory.

traversaro avatar Dec 29 '18 09:12 traversaro

It turns our that in the end FindOctave was never included in CMake upstream: https://gitlab.kitware.com/cmake/cmake/-/issues/18988 .

GitLab
On my system (debian testing + CMake master) the `FindOctave` module sets the `Octave_INCLUDE_DIR` to `/usr/include/octave-4.4.1/octave`. This folder should be `/usr/include/octave-4.4.1` instead. The same issue is inherited by the `Octave::Octave`...

traversaro avatar Apr 21 '20 16:04 traversaro