osqp-eigen icon indicating copy to clipboard operation
osqp-eigen copied to clipboard

Permit to set adaptive_rho related parameters even in embedded mode or if profiler is not defined with osqp v1.0

Open traversaro opened this issue 1 year ago • 4 comments

See:

  • https://github.com/osqp/osqp/blob/4532d356f08789461bc041531f22a1001144c40a/include/public/osqp_api_types.h#L71-L74
  • https://github.com/osqp/osqp/blob/release-0.6.3/include/types.h#L144-L151
  • https://github.com/robotology/osqp-eigen/blob/e535f6faeda431a69a24dc3cdf0ff68541fe37c1/src/Settings.cpp#L79-L89

More in general we need to review any use of EMBEDDED or PROFILING in osqp v1.0 as the macro changed name.

traversaro avatar Nov 12 '24 22:11 traversaro

See https://github.com/jrobbins11/mpc-lib/blame/220f50ed380fef6c0c7cb3427e079e43d079acfd/README.txt#L17-L19 .

traversaro avatar Nov 12 '24 22:11 traversaro

Main issue seems to be this: https://github.com/robotology/osqp-eigen/pull/221

rjoomen avatar Nov 17 '25 14:11 rjoomen

Yes, that what was mentioned in the original issue:

More in general we need to review any use of EMBEDDED or PROFILING in osqp v1.0 as the macro changed name.

If you are interested in fixing this feel free to open a PR, thanks!

traversaro avatar Nov 17 '25 14:11 traversaro

If you are interested in fixing this feel free to open a PR, thanks!

I had missed https://github.com/robotology/osqp-eigen/pull/221 , sorry!

traversaro avatar Nov 17 '25 14:11 traversaro