Trevor Settles
Trevor Settles
> I love these code quality improvements @roboteng :) Just a few nits @Anton-4, Thanks for the feedback, and thanks for looking at this! I'll clean it up some more...
@Anton-4 , Thanks! These are already tests! `cargo test` compiles and runs each example. So as long as we're testing this crate, these are guaranteed to be compiler-checked, and passing....
> ... so breaking changes could go unnoticed. I agree, this would be bad. If we do pull out the code into full tests, I think that should be automated,...
I looked at the check for running tests, and it's just a big regex. It seems doable to change it so that it would consider lines like "/// ```" as...
I want to back up a bit and make sure we're on the same page. The problem is making sure that code examples always stay up to date with the...
> In CI, we can make it run for changes to lines with /// but still skip it for //. That seems like the best trade-off overall. I think I've...
Thanks for your feedback @Anton-4, it's helped make this PR clearer and more consistent! I've gone through and updated as you've suggested
The issue seems to be in the `RednerPlugin` ```rust use bevy::{prelude::*, render::RenderPlugin, window::WindowPlugin}; fn main() { App::new() .add_plugin(WindowPlugin::default()) .add_plugin(AssetPlugin::default()) .add_plugin(RenderPlugin) .run(); } ``` This seg faults, but if I comment...
Hmm, it seems like it's been fixed. Using just the `DefaultPlugins` I don't get the error anymore. When I tried with `WIndowPlugin`, `AssetPlugin`, and `RenderPlugin`, I still got an error,...
Yeah, I just tried running the breakout bevy example, and that worked without modification. My test project works now too. I'm not sure what fixed it, but I think we...