robot_descriptions.py
robot_descriptions.py copied to clipboard
robot-descriptions
Add realsense d435i MJCF.
Pull Request Test Coverage Report for Build 8552222498
Details
- 7 of 7 (100.0%) changed or added relevant lines in 1 file are covered.
- No unchanged relevant lines lost coverage.
- Overall coverage increased (+0.01%) to 98.583%
| Totals | |
|---|---|
| Change from base Build 8520072047: | 0.01% |
| Covered Lines: | 974 |
| Relevant Lines: | 988 |
💛 - Coveralls
Thanks for this PR!
The realsense is rather a robot accessory than a robot description. What would be a typical use case where it is convenient to load the camera in itself? (We could add it as an example too.)
As of right now, this camera is purely for making aesthetic sims (e.g. in the context of creating digital twins). I'm going to send in a PR in the near future that would add MuJoCo cameras to the XML with intrinsics that match the specs of the real camera. We can leave this PR on hold until the corresponding commit in Menagerie lands, at which point this camera becomes useful beyond just pretty aesthetics.
OK, sounds good :+1: I've converted the PR to draft to put it on hold. Feel free to convert it back when it is ready.