Robert O'Rourke

Results 93 comments of Robert O'Rourke

As of WP 5.3.1 any files uploaded with a suffix like `-123x456.jpg` will have a `-1` appended per `wp_unique_filename()`. That solves the issue for newer imports and projects more or...

We should document the use of this CLI command for fixing the issue: https://github.com/humanmade/rename-images-command

We have an implementation of this in the smart media plugin now, could look at porting that across.

Just a proper readme would be good 😬 Really needs a good week or 2 of focus time on this plugin to get things really sweet.

@goldenapples we may need to roll out updates to the tachyon service that handle URL encoding on the JS side too. I'm not sure when it was last deployed and...

A zero value for width or height should probably mean we try and calculate the intrinsic height and use that value first. Any thoughts on that @goldenapples ?

I think we can move forward without bothering Than, it’s a clear bug that we could do with addressing in the function mentioned in the original comment here

Zero is a shorthand for any size - only used sense for non cropped sizes.

Hi @Coop920, the cropping is currently dependent on using [Tachyon](https://github.com/humanmade/Tachyon) and the [Tachyon plugin](https://github.com/humanmade/tachyon-plugin). Do you have those running too?

We check if it's an array and return it in the lines above so it shouldn't be that. It would be good you were able to step debug and see...