Robert O'Rourke

Results 93 comments of Robert O'Rourke

Awesome! I can make a PR later this week unless you know how you'd do it already.

@wupeaking I got that too but it's a separate issue to this one. You should create a new issue and be more descriptive of the problem e.g. What were you...

@johnagan this is pretty well tested now in my current use cases, let me know if you have a better solution in mind.

This was merged upstream in the PyTorch repo 20 days ago but there hasn't been a new docker image released since then: https://github.com/pytorch/pytorch/pull/83437

I realise this isn't the proposed approach in terms of API but I have a working (I think) prototype on this branch: https://github.com/roborourke/sharp/tree/icc-transform It adds a `withIcc()` method to the...

I’ll pick up my branch again and work on adding it in the way proposed here rather than `withIcc()` On Thu, 3 Jan 2019 at 18:23, Chad Johnson wrote: >...

I picked up my work on this again and I've created a pull request #2271 - it's work in progress and I need a little guidance to properly implement everything...

> I read the proposals, and I'm not quiet sure my use case is listed, > I need to resize a tiff while keeping the original color profile (which is...

@hdwong can you make sure you’re using version 0.26.0 and try modifying your code to keep the CMYK profile: ``` sharp('path-to-original.jpg') .withMetadata({ icc: 'cmyk' }) .toFile('path-to-result.jpg'); ```

@archon810 you could try Cavalcade 2.0. Worth noting this doesn't happen all the time - Cavalcade is running on all our production sites and wordpress.org too.