Robert O'Rourke
Robert O'Rourke
Always happy to get pull requests if you have the time to do so 👍
The behaviour isn’t equivalent unfortunately or I would agree on reducing dependencies. The smartcrop-sharp library is a wrapper around https://github.com/jwagner/smartcrop.js so we could perhaps switch to using that directly instead...
Thank you @Diskein !
Additional note - I went with a generated column rather than a [functional index](https://dev.mysql.com/doc/refman/8.0/en/create-index.html#create-index-functional-key-parts) because that would require MySQL 8.0.13 as a minimum requirement. Maybe we're fine with that but...
Hm, unschedule test failing, can't find the record...
It's not a massive amount of extra storage per row, one 32bit column, and the index only needs to be against the hash in this case so it's not duplicating...
Hmm, so in the interests of something that is easy to reason about, we could add the duplicate entry clean up routine perhaps.
This might actually be an issue with the duplicate handling code. Possible if `init` is called twice, then the event listener from the `add()` method will already be there and...
@johnbillion or @mattheu, can I chase this one up? Impacting SEO and likely compatilbiity with other code for users
Yeah sorry, you should remove the back port labels and I’ll leave it to your discretion