robloo

A unified invalidating system like this is a really, really good idea! Like the detail in this PR too. Hope this gets in for 11.0 About the name: I would...

> I'll leave this PR alone for now, because it sounds like the existing invalidation events are already due to be removed/refactored Personally, I'm sorry to hear that but it...

I suppose it's possible something was missed in the renaming of template parts: https://github.com/AvaloniaUI/Avalonia/pull/8793. Just a thought, not saying that's it.

I think `ContextMenu` should now be removed as it is better replaced with `ContextFlyout` which can host a `MenuFlyout`. This moves from the WPF way of doing things to the...

> IIRC we've decided to keep ContextMenu as a legacy but still supported API to simplify porting from WPF I know when Flyout was implemented and ContextMenu was marked as...

@CollinAlpert If its a template part I recommend adding the PART_ prefix as well while you are at it. Otherwise, I'll get to it later.

Roll-up of some things I think should be addressed: - Finally mark ContextMenu as [Obsolete] by flyout. Remove this in 12.0 or something altogether with the menu rewrites. - Items...

Also, FYI: https://github.com/CommunityToolkit/WindowsCommunityToolkit/issues/2722#issuecomment-452137476 The Silverlight version of the DataGrid (same source using in the UWP Windows Community Toolkit and here in Avalonia) has some issues with supporting only a subset...

I dont necessarily think all these analyzers have defined performance benefits. Changing this much code in so many areas when not the original author also risks breaking things. Changes are...

> This specific rule is not about replacing zero length array with a null object, but replacing it with cached Array.Empty() instance Yea, I misunderstood and saw that with the...