robkwan

Hello! I am new to this open-source contribution and I would like to ask if it is ok to try working on it as "good first issue" please. I checked...

Hi @Prathmesh2931 yes, please take it over. Thanks.

Hello! I am new to this open-source contribution and I would like to ask if it is ok to try working on it as "good first issue" please. My plan...

Thanks @christophfroehlich ! Will look into it as you suggested then.

Hi @christophfroehlich, I'd like to ask a few questions to clarify pls. 1. I did try to integrate into the controller_manager/test/test_ros2_control_node_launch.py and when I run: pytest src/ros2_control/controller_manager/test/test_ros2_control_node_launch.py -v it would...

Thanks for prompt reply. My first question is related to this:- Even though ament_add_pytest_test(test_ros2_control_node test/test_ros2_control_node_launch.py) is already in CMakeLists.txt, "colcon test" approach would not trigger the test_ros2_control_node_launch.py but I can...

Hello @christophfroehlich, I made changes to get it working in the controller_manager/test/test_ros2_control_node_launch.py and I did the rebase but I'm still not that confident if I did it correctly or not....

Oops! I realized that I just rebased for the jazzy branch only and will do that for the master next pls...thanks.

Hello @christophfroehlich , I just rebased and merged back to the master branch and hope that it would be ok this time. Thanks!

Hi @christophfroehlich, sorry that I thought that already did it with "git push --force-with-lease origin master" before but it didn't! Therefore, I redid everything again and clicked "Create Pull Request"...