Robin Newhouse comments

Results 14 comments of


                                            Robin Newhouse

Doesn't work with React Native

+1 for this issue. running in to the same problem. I've installed cloudinary-core but the package is still reported missing. Any advice?

Bug#104121: Ensure that PREPAREd statements are shown correctly in PERFORMANCE_SCHEMA.THREADS table

Could we request a review of this PR? Thank you.

Minimize unsafe C functions usage - replace strcat() and strcpy() - continued

Marked as WIP. Investigating failing MTR tests.

Minimize unsafe C functions usage - replace strcat() and strcpy() - continued

Removed changes that were the cause of failing tests. Could this be reviewed? cc @arun-esh

Minimize unsafe C functions usage - replace strcat() and strcpy() - continued

Is this ok to push to 10.4 or would you like me to rebase to 10.5?

Minimize unsafe C functions usage - replace strcat() and strcpy() - continued

@vuvova Rebased to 10.5 @cvicentiu Updated indentation.

MDEV-28914 Extend MTR command "copy_file" to support recursive copy and wildcard

Hi @LinuxJedi, @vuvova, would you be able to re-review the latest changes in this PR? Thank you.

MDEV-30418 : Setting wsrep_slave_threads causes thread hang

This looks good to me! I just added one question, mainly for my own curiosity.

MDEV-249034 fix assersion (prefix_size <= width)

Hi @ahmedmadbouly186, thanks for the submission. Is there a reason you use `if` instead of `DBUG_ASSERT`? More for my own curiosity. Also, have you seen https://github.com/MariaDB/server/pull/2520 which addresses the same...

MDEV-17398 Implement ST_LatFromGeoHash and ST_LongFromGeoHash

Regarding the author attribution, https://github.com/mysql/mysql-server/commit/ad34780e.patch shows [email protected] I would suggest adding the email and full link to the commit.