Robin Chen comments

Results 5 comments of


Robin Chen

'iter_long' misses the substring match when the overlapped pattern doesn't match

@WojciechMula Hi, any chance of fixing this bug? This is quite severe because now the algorithm output is simply **incorrect**. I can give another example to reliably trigger this behavior...

'iter_long' misses the substring match when the overlapped pattern doesn't match

@pombredanne I've put up a simpler example to reproduce this issue. ```python automaton = ahocorasick.Automaton() automaton.add_word("b", "b") automaton.add_word("abc", "abc") automaton.make_automaton() text = "abb" for i, s in automaton.iter_long(text): print(i, s)...

'iter_long' misses the substring match when the overlapped pattern doesn't match

https://github.com/WojciechMula/pyahocorasick/blob/0bd7daa76b7ef7c7146eda86aa3e23b7341c0871/src/AutomatonSearchIterLong.c#L118-L125 I think it's at this if block, when the next node is not `eow`, it's simply skipped. Instead it should output the result pointed by the "dictionary suffix" of...

'iter_long' misses the substring match when the overlapped pattern doesn't match

nvm, the fix is incorrect.

'iter_long' misses the substring match when the overlapped pattern doesn't match

Well, put up another fix with more tests. #174 @pombredanne do you mind to take a look? Thanks.