Robin Bate Boerop comments

Results 83 comments of


                                            Robin Bate Boerop

trafficstars

Document our definitions of 'pending', 'canonical', 'finalized'

Hard to find the instances of code in which this was done incorrectly, so let's not. But, let's document those good definitions, above (if not already?).

Consolidate logic for precomputed block filenames with format `<network_name>-<state_hash>.json`

I went to a special effort to ensure that all log files (back to the one after genesis) have the correct name, in our Granola-local dev env, FYI.

Need tooling to compare our ledgers against the AN checkpoint ledgers

@trevorbernard to add more detail.

Store raw JSON bytes instead of the serialized `PrecomputedBlock` bytes

> Food for thought. Do we necessarily need to store the raw bytes in Rocks if the we treat the blocks directory as immutable and the source of truth? No,...

Database column family names should use a consistent scheme

I suspect that whomever implements this will come up with some good scheme.

Implement a better tree pruning algorithm and delete `prune_interval`

It makes sense to make it a limit, and not a multiplier. Let's do it as part of this issue, I propose.

Implement a better tree pruning algorithm and delete `prune_interval`

A more sophisticated approach might be to prune after a wall-clock amount of time since last pruning. Not sure if we have timers already in the code that would facilitate...

Implement a better tree pruning algorithm and delete `prune_interval`

Maybe a better algorithm is to increment a counter every time a node is added to the graph/tree. Every N (for some parameter N) additions to the tree, the tree...

Using `expect` may cause a panic and in most cases this isn't the desired behavior

@jhult Let me know if you have the desire to audit the code base (even partially) for improper use of 'expect' (causing failure to log errors correctly, or premature failure...

Using `unwrap` may cause a panic and in most cases this isn't intended behavior

@jhult Let me know if you have an appetite for auditing the code for instances of 'unwrap'.