Rob Hogan

Results 150 comments of Rob Hogan

Ah, this is due to [`@babel/plugin-transform-runtime`](https://babeljs.io/docs/babel-plugin-transform-runtime). By default, transformed code is injected with dependencies on `@babel/runtime/helpers/...` to reduce duplication, which is why RN projects need to specify a [dependency on...

Sorry about the delay with this one. At first glance it seems a *bit* arbitrary to add `customTransformOptions` to this (and not other config), but it's a valid use case...

React Native will have Metro with symlink support (minimum behind a flag) from 0.72. The first RC should be out this month, and you can follow that in [Road to...

The handling of those keyboard shortcuts isn't actually part of Metro - it's implemented by `@react-native-community/cli` that wraps Metro, [here](https://github.com/react-native-community/cli/blob/90edee94442c8ca5aac52a74e7bafbf7df32b434/packages/cli-plugin-metro/src/commands/start/watchMode.ts#L51). For the app to "close and not reopen" is strange...

Hi @brieb - this sounds interesting! Yes, we use a Metro-Buck integration for production builds - it’s a good architectural fit. A lot of this integration layer is internal code,...

Hi @alexkrav - this sounds like it could be https://github.com/facebook/metro/pull/928, related to our switch to Terser as a default minifier. Could you check whether the problem goes away by switching...

Thanks for trying that - definitely seems like a different issue and one we're unaware of. Would you be able to put up a minimal GitHub repo or steps I...

I'd like to get to the bottom of this but I'm stuck without a reproduction. On a new project this works: ```sh $ npx react-native@latest init RNMetroIssue938 && cd RNMetroIssue938...

LGTM on the face of it, importing to test inside the FB monorepo. We should bump the [template `devDependency` to ^8.23.0](https://github.com/facebook/react-native/blob/14914bd816538a23fc221c903b1aabf9f9906925/packages/react-native/template/package.json#L27) as well though - I'll add that.

It’s network dependent but it can take a while, mostly for the screenshots / app preview thumbs. That’s just the speed of the underlying native calls so not a lot...