Rob Hogan

Results 85 comments of Rob Hogan

Thanks for looking at this so quickly. I work with the Hermes engine team so we have an interest in (semi-)automating updates to `compat-table` as part of the engine release...

I’d say so. Happy to update those too if the approach looks good to you.

Thanks for the review @ljharb - the reason for the retro syntax though is the jshint lint setup for this project. For example, applying one of the suggestions above (which...

Sounds good to me - I'll assume modern runtime support and apply all the suggestions the linter is happy with

You can use the `QueryInput` option for this, which is passed straight through to underlying DynamoDB call. See [Amazon's docs](http://docs.aws.amazon.com/amazondynamodb/latest/APIReference/API_Query.html) for what the `QueryInput` object should look like. Eg you...

@a3leggeddog There's no built-in way (PR would be welcome for this), but it'd be fairly straightforward to sort the results client-side. S2Utils has a `getEarthDistance` that will work out the...

@murbanowicz note the issue above and in particular: > Please hold off on merging this yet. Also, if you're basing your choices on the maintenance of the library you should...

It turns out this is a bug in `nodes2ts` but the fix is still unreleased. An ugly-but-effective option is to patch `nodes2ts` at run-time with: ```js require('nodes2ts').S2RegionCoverer.FACE_CELLS = [0, 1,...

Put that line in your own app's code, anywhere you like (once per-process should be enough) as long as it's before you call `queryRadius` or `queryRectangle`. You could put it...