Rob Dickinson
Rob Dickinson
This is very exciting! Please let me know if you have any questions or need any assistance. Thanks! --RobD
Thanks so much for the suggestion! It's great to hear interest in pmemkv in this context.
@jzonthemtn I'm looking at a few regex variations that show better performance, but I need to do some more testing to see how accuracy is affected in the data I...
Here's some `phileas-benchmark` results to show the performance improvement on my reference system. ``` java -server -Xmx512M -XX:+AlwaysPreTouch -XX:PerBytecodeRecompilationCutoff=10000 -XX:PerMethodRecompilationCutoff=10000 -jar phileas-benchmark-cmd.jar i_have_a_dream mask_email_addresses 1 15000 CURRENT WITH PR CHANGES...
Hi @jzonthemtn -- apologies for the novel but thought a few notes would help Please start review with test cases, since a miss there affects everything 😀 I picked the...
> But this will cause -374245455400126- to be redacted as XXXXXXXXXXXX instead of just -XXXXXXXXXXXX-. I assume that's not ideal for your use-case? Correct @jzonthemtn , I don't think that's...
@jzonthemtn the only other variation I can think of would be to use `\b except dash` instead of `\b` as the span boundary...but seems like that would underfit when the...
Hey @jzonthemtn I like the approach in `129-credit-card-dashes` -- especially because this can be made policy-driven (even if not at first). The callback idea is flexible but not very governable,...
The first case turns out to be easy to solve with `ignoredPatterns`, since Unix timestamps will always be 13 digits long and have a specific preamble. ``` CreditCard x =...
Well, I'm applying this `ignoredPattern` in multiple places already -- so if Phileas provided an option like that, I'd definitely use it. Beyond the reuse aspect, seems like a nice...