Robert Penner comments

Results 13 comments of


                                            Robert Penner

Level 26 is difficult to understand

Oh, other people struggling with level 26 ended up making zero-height rows, which wasn't a concept previously introduced: https://github.com/thomaspark/gridgarden/issues/23

Level 26 is difficult to understand

Some people stumped by the math in level 26: https://github.com/thomaspark/gridgarden/issues/66

Level 26 is difficult to understand

![image](https://user-images.githubusercontent.com/79827/38165797-3a3ed664-34e7-11e8-9edb-81171165aee0.png) https://twitter.com/miklb/status/850759537665732610

Animation and Motion

Bookmarking

addAsync result doesn't preserve 'has 0 arguments' (.length == 0)

This is fixed in AsUnit 4.0, where TestCase.addAsync() is delegated to Async.add(), which gets a wrapper function of correct length from here: https://github.com/lukebayes/asunit/blob/master/asunit-4.0/src/asunit/framework/TimeoutCommand.as#L83 Robert On Fri, Mar 30, 2012 at...

Error if you inadvertently add test to itself

Do you mean a test suite?

Error if you inadvertently add test to itself

I haven't done much in TestCase or TestSuite. You can pull my changes from master yourself, make the change, and then Luke can pull from you. With Git, the order...

Compile errors in AsynchronousHTTPServiceTestCase

I managed to submit the fix in my fork and sent a pull request.

Reference Error when addAsync() called from within setUp()

Which version of AsUnit are you using? Can you show more of your TestCase code?

Motion token values do not match theme values

@miroslavstastny Thanks for filing this bug. I had noticed this divergence and addressed it in a larger prototyping branch: https://github.com/microsoft/fluentui/pull/30736/commits/e8bd2da01d880451ad901601152cded568b5b5de I will be breaking it up into smaller PRs, one...