Robert Maynard

Results 67 comments of Robert Maynard

OpenSSH can now be used with windows so that is also an approach: ``` * Settings -> Apps -> Optional Features -> Add a feature -> OpenSSH Server * services.msc...

There should be no need to include FindCUDA as we are enabling the language instead. What issue did you see before you made this change?

I agree we need to find a way to ensure that two distinct libraries that have no interaction can safely use Thrust without accidently causing issues due to ABI changes....

> We should just get away from doing this. I agree. I will look at changing the offending code to not expose thrust > I don't think we're ever concerned...

> However, it makes me wonder if this truly solves any problems (compared with no namespace) because some rmm types (for example) will not be compatible with non-RAPIDS libraries. It...

I am working on a pr draft of cudf using cub in a namespace.

With a solution to https://github.com/NVIDIA/cub/issues/545 being merged, I think the best option for cudf is to patch our version of thrust.

> Can't we just use a version of Thrust that makes the same changes? [NVIDIA/thrust#1788](https://github.com/NVIDIA/thrust/issues/1788) No released version of Thrust currently exists have the required changes. Once Thrust 2.1 has...

Sounds reasonable we can use the `1.17.X` branch once the following PR's are merged - https://github.com/NVIDIA/cub/pull/572 - https://github.com/NVIDIA/thrust/pull/1792

Closing this as we are going to use a different approach