Robert Chen comments

Results 23 comments of


                                            Robert Chen

Fix the optimistic data of hold action isn't consistent with backend data

Hm, the only thing we changed was the `reportAction` type. I see that the comment is under `originalMessage > html` in the Onyx data. Perhaps there is there additional formatting/organization...

Fix the optimistic data of hold action isn't consistent with backend data

> The reason is actionName of hold action is HOLDCOMMENT in optimistic data but BE return actionName as ADDCOMMENT Ah, the backend was updated two weeks ago to switch it...

Fix the optimistic data of hold action isn't consistent with backend data

@nkdengineer Looks like we'll be permanently using `ADDCOMMENT` for this moving forward 👍

[HOLD for payment 2024-12-11] [$250] [Held requests] Partial paying a report causes the wrong amounts to show in the LHN

Yep, let's do it! 👍

[HOLD for payment 2024-12-11] [$250] [Held requests] Partial paying a report causes the wrong amounts to show in the LHN

PR reviewed and merged 👍 Looking into BE

[HOLD for payment 2024-12-11] [$250] [Held requests] Partial paying a report causes the wrong amounts to show in the LHN

Potential BE fix in review ^

[HOLD for payment 2024-12-11] [$250] [Held requests] Partial paying a report causes the wrong amounts to show in the LHN

BE fix merged and being deployed today

[HOLD for payment 2024-12-11] [$250] [Held requests] Partial paying a report causes the wrong amounts to show in the LHN

I think we're all set here! The only remaining issue involves seeing a `0.00` amount in the LHN, but we'll be addressing it in a separate issue here: https://github.com/Expensify/App/issues/48093

[HOLD for payment 2024-12-11] [$250] [Held requests] Partial paying a report causes the wrong amounts to show in the LHN

cc: @RachCHopkins for next steps here!

mweb - IOU - Tapping pay elsewhere button in header grey out IOU preview for few seconds

Yep, not a blocker for sure- let me followup on the correct behavior.